Merged
Conversation
jfuss
suggested changes
May 29, 2019
michael-k
changed the title
jfuss
approved these changes
May 29, 2019
Contributor
jfuss
left a comment
jfuss
left a comment
There was a problem hiding this comment.
Thanks for the patch and the great enhancement to the functional tests!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
make_service_responsefor readability and dynamic inclusion of requests' version numberUpgrading requests to 2.22 lifts the upper bound of urllib3 to <1.26. urllib3 1.25 includes fixes for the following vulnerabilities CVE-2019-9740 and CVE-2019-112369 which were also backported to the 1.24 series (included in release 1.24.3).
urllib3 1.25.2+ includes also other improvements like certificate validation, TLSv1.3 support, Brotli support, …. See https://github.com/urllib3/urllib3/blob/1.25.3/CHANGES.rst
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.